[Intel-gfx] [PATCH i-g-t] RFC: split PM workarounds into separate lib

[Daniel Vetter]

On Tue, Dec 08, 2015 at 05:05:12PM -0200, Paulo Zanoni wrote:
> 2015-12-08 11:42 GMT-02:00 Ville Syrjälä <ville.syrjala at linux.intel.com>:
> > On Tue, Dec 08, 2015 at 10:50:39AM +0200, David Weinehall wrote:
> >> Since the defaults for some external power management related settings
> >> prevents us from testing our power management functionality properly,
> >> we have to work around it. Currently this is done from the individual
> >> test cases, but this is sub-optimal.  This patch moves the PM-related
> >> workarounds into a separate library, and adds some code to restore the
> >> previous settings for the SATA link power management while at it.
> >
> > Why is it called "workarounds"? That gives me the impression we're
> > working around something that's supposed to work but doesn't. That's not
> > the case here.
> 
> Well, in theory they could be considered workarounds since IMHO the
> machine is supposed to be saving as much power as it can on an idle
> state, but it isn't. But this more of a philosophical discussion and
> we can debate forever.
> 
> Anyway, if we rename the file to something like lib/igt_pm.c we'll be
> able to move the residency-checking code and possibly more common
> things there, so I'm not against the rename either.

I like the ring of lib/igt_pm.c.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch