[Intel-gfx] [PATCH i-g-t] RFC: split PM workarounds into separate lib
david.weinehall at linux.intel.com
Thu Dec 10 08:01:28 PST 2015
On Tue, Dec 08, 2015 at 03:42:27PM +0200, Ville Syrjälä wrote:
> On Tue, Dec 08, 2015 at 10:50:39AM +0200, David Weinehall wrote:
> > Since the defaults for some external power management related settings
> > prevents us from testing our power management functionality properly,
> > we have to work around it. Currently this is done from the individual
> > test cases, but this is sub-optimal. This patch moves the PM-related
> > workarounds into a separate library, and adds some code to restore the
> > previous settings for the SATA link power management while at it.
> Why is it called "workarounds"? That gives me the impression we're
> working around something that's supposed to work but doesn't. That's not
> the case here.
Workarounds was because we are working around "imperfect" settings
in other components. At least to me power management should be enabled
out of the box, not something that requires admin-level workarounds.
Since we're not in control of said defaults, we have to modify the
settings when we run our tests, hence workarounds.
That said, as I've replied to a later post, igt_pm is fine by me.
Kind regards, David
More information about the Intel-gfx