[Intel-gfx] [PATCH v2] drm/i915: Fix context/engine cleanup order
daniel at ffwll.ch
Fri Dec 11 10:58:27 PST 2015
On Fri, Dec 11, 2015 at 05:26:19PM +0100, Daniel Vetter wrote:
> On Fri, Dec 11, 2015 at 02:59:09PM +0000, Nick Hoath wrote:
> > Swap the order of context & engine cleanup, so that it is now
> > contexts, then engines.
> > This allows the context clean up code to do things like confirm
> > that ring->dev->struct_mutex is locked without a NULL pointer
> > dereference.
> > This came about as a result of the 'intel_ring_initialized() must
> > be simple and inline' patch now using ring->dev as an initialised
> > flag.
> > Rename the cleanup function to reflect what it actually does.
> > Also clean up some very annoying whitespace issues at the same time.
> > v2: Also make the fix in i915_load_modeset_init, not just
> > in i915_driver_unload (Chris Wilson)
> > Signed-off-by: Nick Hoath <nicholas.hoath at intel.com>
> > Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> > Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> > Cc: David Gordon <david.s.gordon at intel.com>
> > Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Queued for -next, thanks for the patch.
Well looked at BAT results still in time before pushing and dropped.
Sounds like you&Mika are looking into what's going on here.
Software Engineer, Intel Corporation
More information about the Intel-gfx