[Intel-gfx] [PATCH 12/13] drm/i915: Add sync framework support to execbuff IOCTL
chris at chris-wilson.co.uk
Mon Dec 14 04:23:29 PST 2015
On Mon, Dec 14, 2015 at 11:46:22AM +0000, John Harrison wrote:
> >>@@ -1341,6 +1375,17 @@ i915_gem_do_execbuffer(struct drm_device
> >>*dev, void *data,
> >> u32 dispatch_flags;
> >> int ret;
> >> bool need_relocs;
> >>+ int fd_fence_complete = -1;
> >>+ int fd_fence_wait = lower_32_bits(args->rsvd2);
> >>+ struct sync_fence *sync_fence;
> >>+ /*
> >>+ * Make sure an broken fence handle is not returned no matter
> >>+ * how early an error might be hit. Note that rsvd2 has to be
> >>+ * saved away first because it is also an input parameter!
> >>+ */
> >Instead of the 2nd sentence maybe say something like "Note that we
> >have saved rsvd2 already for later use since it is also in input
> >parameter!". Like written I was expecting the code following the
> >comment to do that, and then was confused when it didn't. Or maybe
> >my attention span is too short.
> Will update the comment for those who can't remember what they read
> two lines earlier...
Honestly, I thought the complaint here would be that the user's input
parameter is being modified on the error path breaking the ABI
i.e. drmIoctl() will not work.
Chris Wilson, Intel Open Source Technology Centre
More information about the Intel-gfx