[Intel-gfx] [PATCH 1/2] drm/i915: Kill intel_crtc->cursor_bo

Ville Syrjälä ville.syrjala at linux.intel.com
Mon Dec 14 07:30:01 PST 2015


On Mon, Dec 14, 2015 at 11:32:23AM +0000, Chris Wilson wrote:
> On Mon, Dec 14, 2015 at 01:16:47PM +0200, ville.syrjala at linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > 
> > The vma may have been rebound between the last time the cursor was
> > enabled and now, so skipping the cursor gtt offset deduction is not
> > safe unless we would also reset cursor_bo to NULL when disabling the
> > cursor. Just thow cursor_bo to the bin instead since it's lost all
> > other uses thanks to universal plane support.
> 
> You could also mention that since updating the cursor is so slow now
> through the universal-plane support, that a fast path to avoid a few
> writes/checks is also irrelevant.

I can add a note.

At some point we really should start measuring things and try to get
some of the speed back for common stuff like cursor movement and page
flips.

-- 
Ville Syrjälä
Intel OTC


More information about the Intel-gfx mailing list