[Intel-gfx] [PATCH v2 1/2] drm/i915: Kill intel_crtc->cursor_bo

Chris Wilson chris at chris-wilson.co.uk
Mon Dec 14 07:37:25 PST 2015


On Mon, Dec 14, 2015 at 05:35:02PM +0200, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> The vma may have been rebound between the last time the cursor was
> enabled and now, so skipping the cursor gtt offset deduction is not
> safe unless we would also reset cursor_bo to NULL when disabling the
> cursor. Just thow cursor_bo to the bin instead since it's lost all
> other uses thanks to universal plane support.
> 
> Chris pointed out that cursor updates are currently too slow
> via universal planes that micro optimizations like these wouldn't
> even help.
> 
> v2: Add a note about futility of micro optimizations (Chris)
> 
> References: http://lists.freedesktop.org/archives/intel-gfx/2015-December/082976.html
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Takashi Iwai <tiwai at suse.de>
> Cc: Jani Nikula <jani.nikula at linux.intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list