[Intel-gfx] [PATCH 1/7] drm/i915: Consolidate unclaimed mmio detection
chris at chris-wilson.co.uk
Tue Dec 15 06:38:31 PST 2015
On Tue, Dec 15, 2015 at 04:25:06PM +0200, Mika Kuoppala wrote:
> Access the unclaimed reg detection register through
> one helper which also does cleanup. Note that we now access
> the register only if the platform has the actual non claimed
> access bit. This prevents reading the register with gens that
> doesn't have the register or the unclaimed bit,
> when debug_mmio > 0.
> Note that we post after clearing the bit. This makes sure
> that the next unclaimed write access would get detected
> also if it happened right after clearing, and not fold
> into the previous detection.
I didn't like 6 (adding checks to rpm get/put), and I didn't see the
removal of the check from the interrupt? Or adding it to the modesetting
Did I just miss those?
The other patches (1-5?) (aside from adding chv as I haven't validated the
registers myself) are
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
Chris Wilson, Intel Open Source Technology Centre
More information about the Intel-gfx