[Intel-gfx] [PATCH 05/10] drm/i915: add assert_rpm_wakelock_held helper

[Chris Wilson]

On Wed, Dec 16, 2015 at 02:54:43PM +0200, Imre Deak wrote:
> On ke, 2015-12-16 at 12:11 +0000, Chris Wilson wrote:
> > On Tue, Dec 15, 2015 at 08:10:33PM +0200, Imre Deak wrote:
> > > +static inline void
> > > +assert_rpm_device_not_suspended(struct drm_i915_private *dev_priv)
> > > +{
> > > +	WARN_ONCE(dev_priv->pm.suspended,
> > > +		  "Device suspended during HW access\n");
> > > +}
> > 
> > On irc, Joonas expressed a wish to see all errors during an igt run,
> > i.e. something like
> > 
> > static inline void
> > assert_rpm_device_not_suspended(struct drm_i915_private *dev_priv)
> > {
> > 	WARN(dev_priv->pm.suspended &&
> > 	     atomic_inc_return(&dev_priv->pm.errors) < 0,
> > 		  "Device suspended during HW access\n");
> > }
[snip]

> Sounds good, we could use this also for other PM related error
> reporting.
> 
> Are you ok to do this as a follow-up?

Definitely. We haven't changed any behaviour so far, so this is a new
feature.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre