[Intel-gfx] ✗ failure: UK.CI.checkpatch.pl

Patchwork patchwork at annarchy.freedesktop.org
Thu Dec 17 06:48:08 PST 2015


== Summary ==

  • Testing [v2] drm/i915: Introduce drm_i915_gem_request_active for request tracking
  • Testing [02/11] drm/i915: Refactor activity tracking for requests

WARNING: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#680: FILE: drivers/gpu/drm/i915/i915_gem_request.h:123:
+#define RQ_BUG_ON(expr) BUG_ON(expr)

WARNING: storage class should be at the beginning of the declaration
#701: FILE: drivers/gpu/drm/i915/i915_gem_request.h:218:
+inline static void init_request_active(struct drm_i915_gem_request_active *active,

ERROR: inline keyword should sit between storage class and type
#701: FILE: drivers/gpu/drm/i915/i915_gem_request.h:218:
+inline static void init_request_active(struct drm_i915_gem_request_active *active,


Your patch has style problems, please review.

NOTE: Ignored message types: BLOCK_COMMENT_STYLE COMMIT_LOG_LONG_LINE COMPLEX_MACRO FILE_PATH_CHANGES GIT_COMMIT_ID SPLIT_STRING

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

  • Testing [03/11] drm/i915: Rename vma->*_list to *_link for consistency
  • Testing [04/11] drm/i915: Amalgamate GGTT/ppGTT vma debug list walkers
  • Testing [05/11] drm/i915: Reduce the pointer dance of i915_is_ggtt()
  • Testing [06/11] drm/i915: Store owning file on the i915_address_space
  • Testing [07/11] drm/i915: i915_vma_move_to_active prep patch

WARNING: Missing a blank line after declarations
#134: FILE: drivers/gpu/drm/i915/i915_gem_execbuffer.c:1097:
+			struct drm_i915_private *dev_priv = req->i915;
+			list_move_tail(&dev_priv->fence_regs[obj->fence_reg].lru_list,


Your patch has style problems, please review.

NOTE: Ignored message types: BLOCK_COMMENT_STYLE COMMIT_LOG_LONG_LINE COMPLEX_MACRO FILE_PATH_CHANGES GIT_COMMIT_ID SPLIT_STRING

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

  • Testing [08/11] drm/i915: Track active vma requests
  • Testing [10/11] drm/i915: Mark the context and address space as closed
  • Testing [11/11] Revert "drm/i915: Clean up associated VMAs on context destruction"



More information about the Intel-gfx mailing list