[Intel-gfx] [PATCH 5/6] drm/i915: Add helpers to reduce (repetitive) noise

Chris Wilson chris at chris-wilson.co.uk
Thu Dec 17 13:10:58 PST 2015

On Thu, Dec 17, 2015 at 09:25:50PM +0200, Joonas Lahtinen wrote:
> Add helpers to reduce the amount of noise. Use the i915.debug parameter
> introduced in the previous patch to decide on whether to display all
> debug messages or just ones that are meaningful to end user.
> Take for example the CI environment, we want to see all possible warning
> messages even though the system continues to operate. Opposite to that is
> environment in daily use, repeating errors should be displayed once to
> indicate the need for a bug report, but if the machine continues to work,
> we should not spam the user continuously.

One thing, if we have a helper that we think will be generally useful
(outside of our module), we have taken the liberty in the past in giving
it a non-specific name, e.g. WARN_RECUR();

That would mean we would use WARN_RECUR(cond, i915.debug, "foo has barred\n"))

The theory being is that if it is useful we can then lift it to the

Chris Wilson, Intel Open Source Technology Centre

More information about the Intel-gfx mailing list