[Intel-gfx] [PATCH v2] drm/i915: Correct max delay for HDMI hotplug live status checking
daniel at ffwll.ch
Mon Dec 21 03:52:19 PST 2015
On Mon, Dec 21, 2015 at 10:37:25AM +0000, Chris Wilson wrote:
> On Mon, Dec 21, 2015 at 11:29:16AM +0100, Daniel Vetter wrote:
> > On Tue, Dec 15, 2015 at 12:40:30PM +0800, Gary Wang wrote:
> > > The total delay of HDMI hotplug detecting with 30ms have already
> > > been split into a resolution of 3 retries of 10ms each, for the worst
> > > cases. But it still suffered from only waiting 10ms at most in
> > > intel_hdmi_detect(). This patch corrects it by reading hotplug status
> > > with 4 times at most for 30ms delay.
> > >
> > > v2:
> > > - straight up to loop execution for more clear in code readability
> > > - mdelay will replace with msleep by Daniel's new patch
> > >
> > > drm/i915: mdelay(10) considered harmful
> > >
> > > - suggest to re-evaluate try times for being compatible to old HDMI monitor
> > >
> > > Reviewed-by: Cooper Chiou <cooper.chiou at intel.com>
> > > Tested-by: Gary Wang <gary.c.wang at intel.com>
> > > Cc: Jani Nikula <jani.nikula at linux.intel.com>
> > > Cc: Daniel Vetter <daniel at ffwll.ch>
> > > Cc: Gavin Hindman <gavin.hindman at intel.com>
> > > Cc: Sonika Jindal <sonika.jindal at intel.com>
> > > Cc: Shashank Sharma <shashank.sharma at intel.com>
> > > Signed-off-by: Gary Wang <gary.c.wang at intel.com>
> > Queued for -next (including cc: fixes), thanks for the patch.
> Using mdelay() or fixed to use msleep()?
msleep patch was merged already, I just had to resolve the conflict.
Software Engineer, Intel Corporation
More information about the Intel-gfx