[Intel-gfx] [PATCH] [v2] drm/i915: Limit VF cache invalidate workaround usage to gen9
daniel at ffwll.ch
Mon Dec 21 04:05:05 PST 2015
On Fri, Dec 18, 2015 at 12:34:16PM +0200, Imre Deak wrote:
> On pe, 2015-12-18 at 11:59 +0200, Jani Nikula wrote:
> > On Thu, 17 Dec 2015, Imre Deak <imre.deak at intel.com> wrote:
> > > On Thu, 2015-12-17 at 09:49 -0800, Ben Widawsky wrote:
> > > > +> if (IS_GEN9(ring->dev))
> > >
> > > Nitpick: INTEL_INFO()->gen == 9 is the preferred way.
> > Oh? Since when and says who?
> Haven't found it after some digging, but I do remember someone having
> this comment earlier.
> My opinion is that we should only use one form, and since INTEL_INFO()-
> gen can be used in a more generic manner I would prefer that. Currently
> we have it both ways in the code.
We use IS_GENx for individual gen checks and INTEL_INFO()->gen when
checking for ranges. At least that's the usage I inferred ...
Software Engineer, Intel Corporation
More information about the Intel-gfx