[Intel-gfx] [PATCH v5] drm/i915: Avoid writing relocs with addresses in non-canonical form

Winiarski, Michal michal.winiarski at intel.com
Tue Dec 22 03:41:49 PST 2015


On Tue, 2015-12-22 at 12:00 +0100, Michał Winiarski wrote:
> According to bspec, some parts of HW require the addresses to be in
> a canonical form, where bits [63:48] == [47]. Let's convert addresses
> to
> canonical form prior to relocating and return converted offsets to
> userspace. We also need to make sure that userspace is using
> addresses
> in canonical form in case of softpin.
> 
> v2: Whitespace fixup, gen8_canonical_addr description (Chris, Ville)
> v3: Rebase on top of softpin, fix a hole in relocate_entry,
>     s/expect/require (Chris)
> v4: Handle softpin in validate_exec_list (Chris)
> v5: Convert back to canonical form at copy_to_user time (Chris)

Please ignore this one, I'm breaking old execbuffer here.

> 
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Michel Thierry <michel.thierry at intel.com>
> Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Signed-off-by: Michał Winiarski <michal.winiarski at intel.com>
> ---
>  drivers/gpu/drm/i915/i915_gem_execbuffer.c | 107 ++++++++++++++++++-
> ----------
>  1 file changed, 66 insertions(+), 41 deletions(-)


More information about the Intel-gfx mailing list