[Intel-gfx] [PATCH] drm/i915: remove indirection in the PCI ID macros

[Chris Wilson]

On Tue, Feb 03, 2015 at 01:36:00PM +0000, Damien Lespiau wrote:
> On Tue, Feb 03, 2015 at 02:34:05PM +0200, Jani Nikula wrote:
> > Spell all the PCI IDs out to be able to quickly grep for the IDs. No
> > functional changes.
> > 
> > Signed-off-by: Jani Nikula <jani.nikula at intel.com>
> > 
> > ---
> > 
> > I tested this by comparing the results of
> > 
> > $ make drivers/gpu/drm/i915/i915_drv.s
> > $ make arch/x86/kernel/early-quirks.s
> > 
> > before and after the patch. No change.
> 
> I'm sold by the test so:
> 
> Reviewed-by: Damien Lespiau <damien.lespiau at intel.com>
> 
> I did double check with the specs though and found:
> 
>   - 0x160B is marked as reserved
>   - 0x161B is marked as reserved
>   - A few more ids are reserved than the ones in the reserved define
> 
> The reserved ones are non existing SKUs, so meh.

Though we have been caught out in the past when products started
shipping. Userspace depends upon the list being complete (and for not
new PCI IDs being released for old hardware).
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre