[Intel-gfx] [PATCH v2] drm/i915/skl: Make sure to allocate mininum sizes in the DDB

Damien Lespiau damien.lespiau at intel.com
Mon Feb 9 05:59:10 PST 2015


On Mon, Feb 09, 2015 at 03:56:20PM +0200, Ville Syrjälä wrote:
> > @@ -2544,8 +2557,9 @@ skl_allocate_pipe_ddb(struct drm_crtc *crtc,
> >  		 * promote the expression to 64 bits to avoid overflowing, the
> >  		 * result is < available as data_rate / total_data_rate < 1
> >  		 */
> > -		plane_blocks = div_u64((uint64_t)alloc_size * data_rate,
> > -				       total_data_rate);
> > +		plane_blocks = minimum[plane];
> > +		plane_blocks += div_u64((uint64_t)alloc_size * data_rate,
> > +					total_data_rate);
> 
> The minimum[] array seems pointless. The value here is always going to
> be 8.

Not in the future with new features appearing.

-- 
Damien


More information about the Intel-gfx mailing list