[Intel-gfx] [PATCH i-g-t] lib/chipset: Cache devid

[Daniel Vetter]

On Tue, Feb 10, 2015 at 11:39:45PM +0100, Daniel Vetter wrote:
> On Tue, Feb 10, 2015 at 11:37:42PM +0100, Daniel Vetter wrote:
> > On Tue, Feb 10, 2015 at 10:28:22PM +0000, Chris Wilson wrote:
> > > On Tue, Feb 10, 2015 at 10:59:16PM +0100, Daniel Vetter wrote:
> > > > Chris Wilson complained that this adds a lot of noise to the test
> > > > startup when full debugging is enabled, so let's cache it. We can do
> > > > that since there's only ever one intel gpu in a given system.
> > > > 
> > > > Cc: Chris Wilson <chris at chris-wilson.co.uk>
> > > > Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> > > 
> > > Couldn't we move the devid cache to lib/drmtest.c::is_intel() ?
> > 
> > Sounds like just another place where we should use the helper from
> > intel_chipset.c. Next patch in-flight ...
> 
> Ok I'm blind, is_intel can fail. So I guess I should extract a new
> __get_drm_devid which can fail, put the caching in there (plus override)
> and use that in in intel_chipset.c ...

Doesn't really work since doing the ioctl is part of the dance we do to
figure out whether the fd is really an intel or not :(
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch