[Intel-gfx] [RFC v2 0/4] Crystal Cove PMIC based Panel and Backlight Control

[Jani Nikula]

On Fri, 02 Jan 2015, Shobhit Kumar <shobhit.kumar at intel.com> wrote:
> Hi All
> Please find modifed set of patches. Sending as a separate thread as initial
> patches were a crude implementation to trigger discussion, but these have been 
> tested and also do not need intel_soc_pmic_writeb/readb functionaly, but uses
> the regmap interface as suggested by Jacob.
>
> These patches implement a drm_panel as a platform driver for the mfd_cell device
> declared in intel_soc_pmic_core.c. 
>
> Still there are opens, where I need closure - 
> 1. Added a new drm_panel, but how to find the panel in lack of OF info. For now
>    added a drm_panel function to find panel by name.

I don't have an answer.

> 2. Backlight also needs similar pmic based control. Is it okay to add a backlight
>    class driver also as part of this panel driver ?

Is it fathomable you have designs with pmic panel enable/disable but soc
pwm backlight control? If yes, I think you need to separate the two. If
they always go together, I think you can keep them together.

BR,
Jani.

>
> For now I am doing Backlight Enable/Disable also during panel/enable as this will
> at least save power. Backlight control will need a backlight class driver.
>
> Regards
> Shobhit
>
> Shobhit Kumar (4):
>   drm: Add support to find drm_panel by name
>   mfd: Add a new cell device for panel controlled by crystal cove pmic
>   drm/panel: Add new panel driver based on crystal cove pmic
>   drm/i915: Enable DSI panel enable/disable based on PMIC
>
>  drivers/gpu/drm/drm_panel.c                |  18 +++
>  drivers/gpu/drm/i915/Kconfig               |   1 +
>  drivers/gpu/drm/i915/intel_dsi.c           |  16 +++
>  drivers/gpu/drm/i915/intel_dsi.h           |   6 +
>  drivers/gpu/drm/i915/intel_dsi_panel_vbt.c |   1 +
>  drivers/gpu/drm/panel/Kconfig              |   7 ++
>  drivers/gpu/drm/panel/Makefile             |   1 +
>  drivers/gpu/drm/panel/panel-crystalcove.c  | 191 +++++++++++++++++++++++++++++
>  drivers/mfd/intel_soc_pmic_crc.c           |   3 +
>  include/drm/drm_panel.h                    |   3 +
>  10 files changed, 247 insertions(+)
>  create mode 100644 drivers/gpu/drm/panel/panel-crystalcove.c
>
> -- 
> 1.9.1
>

-- 
Jani Nikula, Intel Open Source Technology Center