[Intel-gfx] [PATCH] drm/i915: Do not invalidate obj->pages under mempressure

[Daniel Vetter]

On Thu, Jan 15, 2015 at 08:44:00PM +0000, Chris Wilson wrote:
> On Thu, Jan 15, 2015 at 08:36:15PM +0100, Daniel Vetter wrote:
> > On Wed, Jan 14, 2015 at 9:34 PM, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> > > This (partially) reverts
> > >
> > > commit 5537252b6b6d71fb1a8ed7395a8e5babf91953fd
> > > Author: Chris Wilson <chris at chris-wilson.co.uk>
> > > Date:   Tue Mar 25 13:23:06 2014 +0000
> > >
> > >     drm/i915: Invalidate our pages under memory pressure
> >
> > Shouldn't we also revert the hunk in i915_gem_free_objects? Without
> > the truncate vs. invalidate disdinction it seems to have lost it's
> > reason for existence ...
>
> No, setting MADV_DONTNEED has other nice properties during put_pages() -
> I think it is useful in its own right, for example that is where my page
> stealing code goes...

Well right now I can't make sense of this bit any more (tbh I didn't with
the other code either, but overlooked that while reviewing). When it's
just there for future work but atm dead code I prefer for it to get
removed.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch