[Intel-gfx] [PATCH] drm/i915: Fix and clean BDW PCH identification

Daniel Vetter daniel at ffwll.ch
Wed Jan 21 22:15:15 PST 2015


On Wed, Jan 21, 2015 at 08:40:02PM +0200, Jani Nikula wrote:
> On Wed, 21 Jan 2015, Rodrigo Vivi <rodrigo.vivi at intel.com> wrote:
> > It seems in the past we have BDW with PCH not been propperly identified
> > and we force it to be LPT and we were warning !IS_HASWELL on propper identification.
> >
> > Now that products are out there we are receiveing logs with this incorrect WARN.
> > And also according to local tests on all production BDW here ULT or HALO we don't
> > need this force anymore. So let's clean this block for real.
> >
> > v2: Fix LPT_LP WARNs to avoid wrong warns on BDW_ULT (By Jani).
> >
> > Reference: https://bugs.freedesktop.org/attachment.cgi?id=110972
> >
> > Cc: Jani Nikula <jani.nikula at intel.com>
> > Cc: Paulo Zanoni <paulo.r.zanoni at intel.com>
> > Cc: Xion Zhang <xiong.y.zhang at intel.com>
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
> 
> With the caveat that I have no idea how common the early pre-release
> Broadwells that do *not* have proper pch identification are,

Generally we throw out all preproduction hacks once production machines
are widely available. Which is the case now for bdw, so imo no concern.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the Intel-gfx mailing list