[Intel-gfx] [PATCH] drm/atomic: Add drm_crtc_state->active

[Thierry Reding]

On Thu, Jan 22, 2015 at 08:04:33AM +0100, Daniel Vetter wrote:
[...]
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
[...]
> @@ -1391,6 +1395,12 @@ static int drm_mode_create_standard_properties(struct drm_device *dev)
>  		return -ENOMEM;
>  	dev->mode_config.prop_crtc_id = prop;
>  
> +	prop = drm_property_create_bool(dev, DRM_MODE_PROP_ATOMIC,
> +			"ACTIVE");

We seem to have a weird mix of property names. Some are all caps, others
all lowercase. I guess we can't really make it consistent anymore since
the only one so far that stands out is "type" and we've already exposed
that to userspace, so ABI...

Otherwise, this looks good, but I don't feel like I understand this good
enough to give my Reviewed-by. I'll go give this a spin on Tegra, see if
that improves my understanding.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20150122/d6ed604e/attachment.sig>