[Intel-gfx] [PATCH 1/4] drm/i915: Update PMINTRMSK on VLV/CHV after sysfs min/max freq change

Chris Wilson chris at chris-wilson.co.uk
Sun Jan 25 01:31:45 PST 2015


On Fri, Jan 23, 2015 at 09:04:23PM +0200, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Currently we don't call valleyview_set_rps() when changing the min/max
> limits through sysfs if the current frequency is still within the new
> limits. However that means we sometimes forget to update PMINTRMSK.
> Eg. if the current frequency is at the old minimum, and then we reduce
> the minum further we should then enable the 'down' interrupts in PMINTRMSK
> but currently we don't.
> 
> Fix it up by always calling valleyview_set_rps() (just like we do for
> !vlv/chv platforms). This also allows the code to be simplified a bit.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list