[Intel-gfx] [PATCH 4/4] i810: coverty fix - avoid random stack access

Chris Wilson chris at chris-wilson.co.uk
Mon Jan 26 04:41:26 PST 2015


On Mon, Jan 26, 2015 at 12:25:43PM +0000, Patrick Welche wrote:
> From: Christos Zoulas <christos at netbsd.org>
> 
> CID 1107540: Make the code safe avoiding random stack access. In
> the first loop where there is a singleton point to pptSrc, only
> access that singleton, no matter what.

By "singleton point" do you mean nbox==1? That's the only case I can see
in which the loop is dangerous (i.e. it will read beyond the end of the
array), but that loop is not accessed if nbox==1.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list