[Intel-gfx] [PATCH 1/3] drm/i915: Do uncore early sanitize after domain init

[Chris Wilson]

On Wed, Jan 28, 2015 at 02:43:24PM +0200, Mika Kuoppala wrote:
> intel_uncore_early_sanitize() will reset the forcewake registers. When
> forcewake domains were introduced, the domain init was done after the
> sanitization of the forcewake registers. And as the resetting of
> registers use the domain accessors, we tried to reset the forcewake
> registers with unitialized forcewake domains and failed.
> 
> Fix this by sanitizing after all the domains have been initialized. Do
> per domain clearing of forcewake register on domain init so that
> IVB can do early access to ECOBUS do determine the final configuration.
> 
> This regression was introduced in
> 
> commit 05a2fb157e44a53c79133805d30eaada43911941
> Author: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> Date:   Mon Jan 19 16:20:43 2015 +0200
> 
>     drm/i915: Consolidate forcewake code
> 
> v2: Carve out ellc detect, fw_domain_reset for ivb/ecobus (Chris)
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88805
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Reported-by: Olof Johansson <olof at lixom.net>
> Tested-by: Darren Hart <dvhart at linux.intel.com> (v1)
> Signed-off-by: Mika Kuoppala <mika.kuoppala at intel.com>

Looks good to me, I hope it survives booting...
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre