[Intel-gfx] [PATCH] drm/i915: Don't dereference NULL plane while setting up scalers

Daniel Vetter daniel at ffwll.ch
Mon Jul 6 12:25:17 PDT 2015


On Mon, Jul 06, 2015 at 09:19:24AM -0700, Matt Roper wrote:
> intel_atomic_setup_scalers() dereferences 'plane' before the plane has
> been assigned.  The plane ID assignment doing this dereference is only
> needed for debugging messages later in the function, so just move the
> assignment farther down the function to a point where plane will no
> longer be NULL.
> 
> This was introduced in:
> 
>         commit 133b0d128be39e308ccd3b3d765c31ebdbf5380e
>         Author: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
>         Date:   Mon Jun 15 12:33:39 2015 +0200
> 
>             drm/i915: Clean up intel_atomic_setup_scalers slightly.
> 
> Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> Cc: Bob Paauwe <bob.j.paauwe at intel.com>
> Reported-by: Bob Paauwe <bob.j.paauwe at intel.com>
> Signed-off-by: Matt Roper <matthew.d.roper at intel.com>

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the Intel-gfx mailing list