[Intel-gfx] linux-4.2-rc1/drivers/gpu/drm/i915/intel_csr.c:353: bad if statement ?

[Manna, Animesh]

Sure I will send a patch correcting the condition.

Regards,
Animesh

-----Original Message-----
From: Deak, Imre 
Sent: Tuesday, July 7, 2015 8:03 PM
To: David Binderman; Manna, Animesh
Cc: Vetter, Daniel; Jani Nikula; intel-gfx at lists.freedesktop.org
Subject: Re: [Intel-gfx] linux-4.2-rc1/drivers/gpu/drm/i915/intel_csr.c:353: bad if statement ?

On ti, 2015-07-07 at 10:51 +0000, David Binderman wrote:
> Hello there,
> 
> [linux-4.2-rc1/drivers/gpu/drm/i915/intel_csr.c:353]: (warning) Logical conjunction always evaluates to false: EXPR < 524288 && EXPR> 589823.
> 
> Source code is
> 
>       if (dmc_header->mmioaddr[i] < CSR_MMIO_START_RANGE &&
>             dmc_header->mmioaddr[i]> CSR_MMIO_END_RANGE) {
> 
> Maybe better code
> 
>       if (dmc_header->mmioaddr[i] < CSR_MMIO_START_RANGE ||
>             dmc_header->mmioaddr[i]> CSR_MMIO_END_RANGE) {
> 
> Regards
> 
> David Binderman

Thanks for reporting it, review fail on my side. Animesh could you send a patch to fix this up?

Thanks,
Imre