[Intel-gfx] commit dec4f799d0a4c9edae20512fa60b0a36f3299ca2 laptop reboots or hangs at boot time
Hans de Bruin
jmdebruin at xmsnet.nl
Sun Jul 12 12:56:07 PDT 2015
Daniel,
commit dec4f799d0a4c9edae20512fa60b0a36f3299ca2 causes my laptop to hang
or reboot at the moment the kernel swiches the vido mode at boot time. I
also noticed a warning while compiling:
CC drivers/gpu/drm/i915/i915_gem_gtt.o
/usr/src/linux.bisect/drivers/gpu/drm/i915/i915_gem_gtt.c: In function
'gen8_ppgtt_init':
/usr/src/linux.bisect/drivers/gpu/drm/i915/i915_gem_gtt.c:954:2:
warning: large integer implicitly truncated to unsigned type [-Woverflow]
ppgtt->base.total = 1ULL << 32;
^
It might be related, or not.
--
Hans
commit dec4f799d0a4c9edae20512fa60b0a36f3299ca2
Author: Daniel Vetter <daniel.vetter at ffwll.ch>
Date: Tue Jul 7 11:15:47 2015 +0200
drm/i915: Use crtc_state->active in primary check_plane func
Since
commit 8c7b5ccb729870e606321b3703e2c2e698c49a95
Author: Ander Conselvan de Oliveira
<ander.conselvan.de.oliveira at intel.com>
Date: Tue Apr 21 17:13:19 2015 +0300
drm/i915: Use atomic helpers for computing changed flags
we compute the plane state for a modeset before actually committing
any changes, which means crtc->active won't be correct yet. Looking at
future work in the modeset conversion targetting 4.3 the only places
where crtc_state->active isn't accurate is when disabling other CRTCs
than the one the modeset is for (when stealing connectors). Which
isn't the case here. And that's also confirmed by an audit, we do
unconditionally update crtc_state->active for the current pipe.
We also don't need to update any other plane check functions since we
only ever add the primary state to the modeset update right now.
Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira at intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
Cc: Jani Nikula <jani.nikula at linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
Reviewed-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
More information about the Intel-gfx
mailing list