[Intel-gfx] [PATCH] drm/i915: fix possible null pointer dereference

Sudip Mukherjee sudipm.mukherjee at gmail.com
Mon Jul 20 05:29:29 PDT 2015


We were dereferencing dev first and then checking if it is NULL. Lets
check for NULL first and then dereference.

Signed-off-by: Sudip Mukherjee <sudip at vectorindia.org>
---
 drivers/gpu/drm/i915/i915_debugfs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index bc817da..f316e49 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -4100,12 +4100,13 @@ static int i915_displayport_test_active_show(struct seq_file *m, void *data)
 {
 	struct drm_device *dev = m->private;
 	struct drm_connector *connector;
-	struct list_head *connector_list = &dev->mode_config.connector_list;
+	struct list_head *connector_list;
 	struct intel_dp *intel_dp;
 
 	if (!dev)
 		return -ENODEV;
 
+	connector_list = &dev->mode_config.connector_list;
 	list_for_each_entry(connector, connector_list, head) {
 
 		if (connector->connector_type !=
-- 
1.8.1.2



More information about the Intel-gfx mailing list