[Intel-gfx] [PATCH 5/5] drm/i915: Make wait_for_flips interruptible.

Maarten Lankhorst maarten.lankhorst at linux.intel.com
Tue Jul 21 01:02:43 PDT 2015


Op 21-07-15 om 08:51 schreef Daniel Vetter:
> On Mon, Jul 20, 2015 at 04:52:11PM +0200, Maarten Lankhorst wrote:
>> Op 16-07-15 om 14:57 schreef Maarten Lankhorst:
>>> Move it from intel_crtc_atomic_commit to prepare_plane_fb.
>>> Waiting is done before committing, otherwise it's too late
>>> to undo the changes.
>>>
>>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
>>> ---
>>>  drivers/gpu/drm/i915/intel_atomic.c  |  2 -
>>>  drivers/gpu/drm/i915/intel_display.c | 72 +++++++++++++++++-------------------
>>>  drivers/gpu/drm/i915/intel_drv.h     |  2 -
>>>  3 files changed, 33 insertions(+), 43 deletions(-)
>>>
>> This breaks DPMS off, because it might wait for flips before continuing.
>> It looks like all drivers use drmModeConnectorSetProperty correctly,
>> so it's safe to fix dpms to return an error.
>>
>> Can I get the changes to dpms handling in intel applied first, and the first 4 patches from this series?
>
Ok patch sent to dri-devel, after dpms returns a value this patch should be safe to apply.

~Maarten


More information about the Intel-gfx mailing list