[Intel-gfx] [PATCH 4/5] drm/i915: Remove wait_for_pending_flips from disable_noatomic.

[Chris Wilson]

On Tue, Jul 21, 2015 at 02:38:14PM +0200, Maarten Lankhorst wrote:
> Op 21-07-15 om 13:35 schreef Chris Wilson:
> > On Thu, Jul 16, 2015 at 02:57:50PM +0200, Maarten Lankhorst wrote:
> >> Now that intel_display_suspend is atomic it's safe to remove
> >> wait_for_pending_flips from intel_crtc_disable_noatomic. It
> >> will only be used during hw load or resume, in which case there
> >> will be no pending flips anyway.
> > A WARN_ON(pending_flip) then? (Actually we should start doing
> > DRM_ERROR_ON I guess that would make a lot of complaints go away, and
> > also a lot of genuine bug reports) Or do we have warning coverage
> > elsewhere along the CRTC change path?
> 
> intel_sanitize_crtc, called during hw readout, is the only caller of intel_crtc_disable_noatomic.
> During hw readout no sw updates should be queued anyway..

Is there any documentation to say that this function can't ever be
called outside of sanitize_crtc? Perhaps rename the function to reflect
its usage?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre