[Intel-gfx] [PATCH] mfd: Add GPIOLIB dependency if INTEL_SOC_PMIC is to be enabled

Daniel Vetter daniel at ffwll.ch
Thu Jul 23 00:49:22 PDT 2015


On Thu, Jul 23, 2015 at 9:38 AM, Lee Jones <lee.jones at linaro.org> wrote:
> On Wed, 22 Jul 2015, Daniel Vetter wrote:
>> On Wed, Jul 22, 2015 at 02:01:44PM +0530, Shobhit Kumar wrote:
>> > This is needed as the CRC PMIC has support for Panel
>> > enable/diable as gpio which needs 'gpiod_add_lookup_table'
>> > and 'gpiod_remove_lookup_table' from gpiolib. This patch
>> > can be squashed with below commit in topic/crc-pmic branch
>> >
>> >     commit 61dd2ca2d44e493b050adbbb75bc50db11c367dd
>> >     Author: Shobhit Kumar <shobhit.kumar at intel.com>
>> >     Date:   Fri Jun 26 14:32:05 2015 +0530
>> >
>> >     mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO
>> >     signal
>> >
>> >     On some Intel SoC platforms, the panel enable/disable signals
>> >     are controlled by CRC PMIC. Add those control as a new GPIO in a
>> >     lookup table for gpio-crystalcove chip during CRC driver load
>> >
>> > Cc: Lee Jones <lee.jones at linaro.org>
>> > Cc: Linus Walleij <linus.walleij at linaro.org>
>> > Signed-off-by: Shobhit Kumar <shobhit.kumar at intel.com>
>>
>> Applied, thanks.
>
> You can't just apply changes made to other subsystems willy-nilly.
>
> You should wait for an Ack, despite the triviality of the patch, even
> if it's just out of courtesy.

Sorry about that, figured getting rid of the compile fail asap is
better. Should I revert it again and update the pull request?
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the Intel-gfx mailing list