[Intel-gfx] [PATCH 17/18] drm/i915/skl: Removed csr firmware load in resume path.

[Sunil Kamath]

On Tuesday 28 July 2015 04:53 PM, Sunil Kamath wrote:
> On Sunday 26 July 2015 12:30 AM, Animesh Manna wrote:
>> As csr firmware is taking care of loading the firmware,
>> so no need for driver to load again.
>>
>> Cc: Damien Lespiau <damien.lespiau at intel.com>
>> Cc: Imre Deak <imre.deak at intel.com>
>> Cc: Sunil Kamath <sunil.kamath at intel.com>
>> Signed-off-by: Animesh Manna <animesh.manna at intel.com>
>> Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju at intel.com>
>> ---
>>   drivers/gpu/drm/i915/i915_drv.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_drv.c 
>> b/drivers/gpu/drm/i915/i915_drv.c
>> index 77b35fd..f5e720b 100644
>> --- a/drivers/gpu/drm/i915/i915_drv.c
>> +++ b/drivers/gpu/drm/i915/i915_drv.c
>> @@ -1048,7 +1048,6 @@ static int skl_resume_prepare(struct 
>> drm_i915_private *dev_priv)
>>           skl_disable_dc6(dev_priv);
>>         skl_init_cdclk(dev_priv);
>> -    intel_csr_load_program(dev_priv);
>
> The context save and restore program is reset on cold boot, warm 
> reset, PCI function level reset, and hibernate/suspend.
>
> Will it not impact?
>
> - Sunil

If the concern is about checking DC5/DC6 counters, isn't it good idea to 
add that as debug print before f/w reload?
Than to avoid completely reloading of entire firmware?

- Sunil
>>         return 0;
>>   }
>