[Intel-gfx] [PATCH] drm/atomic: Handle vblank events in atomic ioctl correctly.

Daniel Stone daniel at fooishbar.org
Mon Jun 1 11:20:59 PDT 2015


Hi,

On 1 June 2015 at 19:12, Maarten Lankhorst
<maarten.lankhorst at linux.intel.com> wrote:
>                                 drm_framebuffer_reference(new_fb);
>                         plane->fb = new_fb;
>                         plane->crtc = plane->state->crtc;
> +                       drm_framebuffer_unreference(plane->old_fb);

NAK: this is missing a NULL-pointer check on old_fb. R-b stands if
that's fixed though.

Cheers,
Daniel


More information about the Intel-gfx mailing list