[Intel-gfx] [PATCH] perf/x86/intel/pt: Fix lockdep interaction

Alexander Shishkin alexander.shishkin at linux.intel.com
Thu Jun 4 06:24:43 PDT 2015


Tvrtko Ursulin <tvrtko.ursulin at linux.intel.com> writes:

> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>
> Since this drivers creates attributes on the heap, lockdep
> gets upset and disabled itself.
>
> Fix by setting ignore_lockdep flags for problematic attributes.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> Cc: Alexander Shishkin <alexander.shishkin at linux.intel.com>
> Cc: Ingo Molnar <mingo at kernel.org>
> Cc: Peter Zijlstra (Intel) <peterz at infradead.org>
> Cc: x86 at kernel.org
> Cc: MichaƂ Winiarski <michal.winiarski at intel.com>
> ---
> Not saying this is a right fix but lets say I am trying to force the issue. :)

You're right, that's not the real problem, but thanks for reporting. :)

> ---
>  arch/x86/kernel/cpu/perf_event_intel_pt.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/perf_event_intel_pt.c b/arch/x86/kernel/cpu/perf_event_intel_pt.c
> index ffe666c..1cff27b 100644
> --- a/arch/x86/kernel/cpu/perf_event_intel_pt.c
> +++ b/arch/x86/kernel/cpu/perf_event_intel_pt.c
> @@ -153,9 +153,10 @@ static int __init pt_pmu_hw_init(void)
>  
>  		sysfs_attr_init(&de_attrs->attr.attr);

The real problem is this ^^^, should be

  		sysfs_attr_init(&de_attr->attr.attr);

Regards,
--
Alex


More information about the Intel-gfx mailing list