[Intel-gfx] [PATCH] drm/i915: Correcting the reg definitions for PORT_DFT

[Mathai, Minu]

This change is needed for some hardware composer tests in chv.

-----Original Message-----
From: Ville Syrjälä [mailto:ville.syrjala at linux.intel.com] 
Sent: Friday, June 5, 2015 2:08 PM
To: Mathai, Minu
Cc: intel-gfx at lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Correcting the reg definitions for PORT_DFT

On Fri, Jun 05, 2015 at 02:00:24PM +0100, Minu Mathai wrote:
> From: Minu <minu.mathai at intel.com>
> 
> Display CRCs were not readable because the register defintions for 
> PORT_DFT_I9XX and PORT_DFT2_G4X were wrong.
> MMIO offset needs to be added to these register offsets to fix them.
> 
> Issue: GMINL-6869
> Signed-off-by: Minu Mathai <minu.mathai at intel.com>
> ---
>  drivers/gpu/drm/i915/i915_reg.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_reg.h 
> b/drivers/gpu/drm/i915/i915_reg.h index 7213224..c327c7c 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -3193,7 +3193,7 @@ enum skl_disp_power_wells {
>  #define PCH_HDMIC	0xe1150
>  #define PCH_HDMID	0xe1160
>  
> -#define PORT_DFT_I9XX				0x61150
> +#define PORT_DFT_I9XX				(dev_priv->info.display_mmio_offset + 0x61150)

PORT_DFT_I9XX isn't used on VLV/CHV, so this doesn't change anything.


>  #define   DC_BALANCE_RESET			(1 << 25)
>  #define PORT_DFT2_G4X		(dev_priv->info.display_mmio_offset + 0x61154)
>  #define   DC_BALANCE_RESET_VLV			(1 << 31)
> --
> 1.9.1
> 
> ---------------------------------------------------------------------
> Intel Corporation (UK) Limited
> Registered No. 1134945 (England)
> Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47
> 
> This e-mail and any attachments may contain confidential material for 
> the sole use of the intended recipient(s). Any review or distribution 
> by others is strictly prohibited. If you are not the intended 
> recipient, please contact the sender and delete all copies.
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Ville Syrjälä
Intel OTC