[Intel-gfx] [PATCH 0/4] drm: Add decoding for DRM/KMS and i915 ioctls

[Patrik Jakobsson]

On Tue, Jun 09, 2015 at 03:51:05PM +0200, Gabriel Laskar wrote:
> On Tue,  9 Jun 2015 13:26:40 +0200
> Patrik Jakobsson <patrik.jakobsson at linux.intel.com> wrote:
> 
> > This set of patches adds a dispatcher for handling DRM ioctls. The
> > kernel headers for DRM might not be available on all distributions
> > so we depend on libdrm for those. If libdrm is not available we fall
> > back on the kernel headers. Since DRM drivers share the same range of
> > private ioctl numbers I've added a function for detecting the driver
> > based on it's name.
> > 
> > Patrik Jakobsson (4):
> >   drm: Add config for detecting libdrm
> >   drm: Add dispatcher and driver identification for DRM
> >   drm: Add decoding of i915 ioctls
> >   drm: Add decoding of DRM and KMS ioctls
> > 
> >  Makefile.am                |   2 +
> >  configure.ac               |   4 +
> >  defs.h                     |   8 +-
> >  drm.c                      | 613 +++++++++++++++++++++++++++++++++++++++++++++
> >  drm_i915.c                 | 287 +++++++++++++++++++++
> >  io.c                       |   2 +-
> >  ioctl.c                    |  19 +-
> >  xlat/drm_i915_getparams.in |  28 +++
> >  xlat/drm_i915_ioctls.in    |  51 ++++
> >  xlat/drm_i915_setparams.in |   4 +
> >  10 files changed, 1015 insertions(+), 3 deletions(-)
> >  create mode 100644 drm.c
> >  create mode 100644 drm_i915.c
> >  create mode 100644 xlat/drm_i915_getparams.in
> >  create mode 100644 xlat/drm_i915_ioctls.in
> >  create mode 100644 xlat/drm_i915_setparams.in
> > 
> 
> Nice work!
> 
> This looks good to me. I have just tested it a little.
> 
> You should rebase to master, it does not apply for the moment, and add
> the Changelog info in your commits (looks at the log, the global
> Changelog is extracted from the commit messages).
> 
> Other little remarks are inlines in the patches.

Thanks for the review. I'll rebase and add the changelog.

Will send out a v2 of the series tomorrow.

Cheers
Patrik
> 
> -- 
> Gabriel Laskar