[Intel-gfx] [PATCH] drm/i915: Correcting the reg definitions for PORT_DFT
Jani Nikula
jani.nikula at linux.intel.com
Wed Jun 10 05:50:32 PDT 2015
On Wed, 10 Jun 2015, Dave Gordon <david.s.gordon at intel.com> wrote:
> But since INTEL_INFO() can take 'dev_priv' as a parameter (as an
> alternative to 'dev'), all the uses of 'dev' here could be replaced by
> 'dev_priv' and then the parameter changed to pass that directly, thus
> potentially eliminating quite a few extra memory references. Applied
> driver-wide, that micro-optimisation might add up to something useful :)
I think we haven't done that driver-wide because it would be more
disruptive than beneficial, but we're slowly moving at that direction
whenever we change stuff. And this is exactly the reason why Chris
hacked INTEL_INFO et al. to accept either dev or dev_priv.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
More information about the Intel-gfx
mailing list