[Intel-gfx] DC6 already programmed to be disabled

[Daniel Vetter]

On Thu, Jun 04, 2015 at 10:41:42AM +0100, Damien Lespiau wrote:
> On Thu, Jun 04, 2015 at 01:39:50PM +0530, Sagar Arun Kamble wrote:
> > The warning faced by Chandra has to corrected. This warning is not
> > related to firmware load. 
> > 
> > Issue is -> During boot DC5/6 will be already disabled and hence While
> > enabling PW2 for the first time the check to see if DC5/6 is already
> > disabled does not make sense.
> > 
> > So condition should be
> > 
> > WARN(!(I915_READ(DC_STATE_EN) & DC_STATE_EN_UPTO_DC6) && pg2_enabled),
> > 	"DC6 already programmed to be disabled.\n");
> 
> Hi,
> 
> we may talk about different problems here. The warn in question here is
> when the DMC firmware isn't loaded (because, for instance, it's not on
> the filesystem)

Also the initial power domains tricks should result in us not trying to
double-disable stuff on driver load. It works under the assumption that
the bios hasn't enabled any power conservation tricks. If that assumption
ever proves wrong then we need to replace the hard-coded list of initial
power domains with a dynamically generated one. Unfortuantely that also
means fixing up our init code to properly take power domain references, so
quite a bit of work.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch