[Intel-gfx] [PATCH] drm/i915: Use helper to set CRTC state's mode

[Matt Roper]

On Mon, Jun 08, 2015 at 06:59:38AM +0200, Maarten Lankhorst wrote:
> Hey,
> 
> Op 06-06-15 om 00:08 schreef Matt Roper:
> > We need to call drm_atomic_set_mode_for_crtc() rather than copying the
> > mode in manually.  As of commit
> >
> >         commit 99cf4a29fa24461bbfe22125967188a18383eb5c
> >         Author: Daniel Stone <daniels at collabora.com>
> >         Date:   Mon May 25 19:11:51 2015 +0100
> >
> >             drm/atomic: Add current-mode blob to CRTC state
> >
> > the helper now also takes care of setting up the mode property blob for
> > us; if we don't use the helper and never setup the mode blob, this will
> > also trigger a failure in drm_atomic_crtc_check() when we have the
> > DRIVER_ATOMIC flag set (i.e., when using the nuclear pageflip support
> > via i915.nuclear_pageflip kernel command line parameter).
> >
> > Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> > Signed-off-by: Matt Roper <matthew.d.roper at intel.com>
> You're probably correct, but convert to atomic part 3 removes this code entirely. :-)

I'm probably getting confused by all the different spins of atomic
conversion series now, but it looks like this is still needed, even on
top of your latest "Convert to atomic, part 3" set (from June 15th);
we'll end up with no mode blob which leads to warnings and failures from
the DRM core if we don't apply a fix like this to use the helper
function.


Matt

> 
> ~Maarten

-- 
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795