[Intel-gfx] [PATCH v5] drm/i915 : Added Programming of the MOCS

[Damien Lespiau]

>>On Thu, Jun 18, 2015 at 03:45:44PM +0100, Antoine, Peter wrote:
>> So, intializing the other (non-render) MOCS in gen8_init_rcs_context()
>> isn't the most logical thing to do I'm afraid. What happens if we
>> suddenly decide that we don't want to fully initialize the default
>> context at startup but initialize each ring on-demand for that context
>> as well? We can end up in a situation where we use the blitter first
>> and we wouldn't have the blitter MOCS initialized.
>> 
>> In that sense, that code makes an assumption about how we do things in
>> a completely different part of the driver and that's always a
>> potential source of bugs.
>> 
>
>Yes, but this is the same with the golden context and the workarounds
>(as I understand it) so all this code would have to be moved. 

Ah, but the workarounds in that function are only for registers in the
render context, not other rings/engine.

-- 
Damien