[Intel-gfx] [PATCH i-g-t 1/5] stats: Be more precise and talk about mean, not average

Damien Lespiau damien.lespiau at intel.com
Thu Jun 25 16:26:55 PDT 2015


There are several types of averages eg. mean, median and mode.

Signed-off-by: Damien Lespiau <damien.lespiau at intel.com>
---
 lib/igt_stats.c           |  2 +-
 lib/igt_stats.h           |  2 +-
 lib/tests/igt_stats.c     | 10 +++++-----
 tools/skl_compute_wrpll.c |  3 ++-
 4 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/lib/igt_stats.c b/lib/igt_stats.c
index fcf7abe..e6babde 100644
--- a/lib/igt_stats.c
+++ b/lib/igt_stats.c
@@ -44,7 +44,7 @@ void igt_stats_push(igt_stats_t *stats, uint64_t value)
 	stats->values[stats->n_values++] = value;
 }
 
-double igt_stats_get_average(igt_stats_t *stats)
+double igt_stats_get_mean(igt_stats_t *stats)
 {
 	unsigned int i;
 	double a = 0.0;
diff --git a/lib/igt_stats.h b/lib/igt_stats.h
index 99dc1c9..a46b399 100644
--- a/lib/igt_stats.h
+++ b/lib/igt_stats.h
@@ -33,4 +33,4 @@ typedef struct {
 void igt_stats_init(igt_stats_t *stats, unsigned int capacity);
 void igt_stats_fini(igt_stats_t *stats);
 void igt_stats_push(igt_stats_t *stats, uint64_t value);
-double igt_stats_get_average(igt_stats_t *stats);
+double igt_stats_get_mean(igt_stats_t *stats);
diff --git a/lib/tests/igt_stats.c b/lib/tests/igt_stats.c
index e75a203..3f45314 100644
--- a/lib/tests/igt_stats.c
+++ b/lib/tests/igt_stats.c
@@ -25,10 +25,10 @@
 #include "igt_core.h"
 #include "igt_stats.h"
 
-static void test_average(void)
+static void test_mean(void)
 {
 	igt_stats_t stats;
-	double average;
+	double mean;
 
 	igt_stats_init(&stats, 5);
 
@@ -38,12 +38,12 @@ static void test_average(void)
 	igt_stats_push(&stats, 8);
 	igt_stats_push(&stats, 10);
 
-	average = igt_stats_get_average(&stats);
+	mean = igt_stats_get_mean(&stats);
 
-	igt_assert(average == (2 + 4 + 6 + 8 + 10) / 5.);
+	igt_assert(mean == (2 + 4 + 6 + 8 + 10) / 5.);
 }
 
 igt_simple_main
 {
-	test_average();
+	test_mean();
 }
diff --git a/tools/skl_compute_wrpll.c b/tools/skl_compute_wrpll.c
index 9245724..cf808c7 100644
--- a/tools/skl_compute_wrpll.c
+++ b/tools/skl_compute_wrpll.c
@@ -917,7 +917,8 @@ static void test_run(struct test_ops *test)
 	}
 
 	printf("even/odd dividers: %d/%d\n", p_odd_even[0], p_odd_even[1]);
-	printf("average deviation: %.2lf\n", igt_stats_get_average(&stats));
+	printf("mean central freq deviation: %.2lf\n",
+	       igt_stats_get_mean(&stats));
 
 	igt_stats_fini(&stats);
 }
-- 
2.1.0



More information about the Intel-gfx mailing list