[Intel-gfx] [PATCH 7/8] drm/i915: reduce struct_mutex coverage at intel_crtc_page_flip()

Paulo Zanoni przanoni at gmail.com
Tue Jun 30 06:53:11 PDT 2015


From: Paulo Zanoni <paulo.r.zanoni at intel.com>

Neither intel_fbc_disable() nor intel_frontbuffer_flip_prepare() need
that lock.

That intel_fbc_disable() call over there can also certainly be
improved, but let's do it on its own commit.

Signed-off-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
---
 drivers/gpu/drm/i915/intel_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index eab5aa1..0d98332 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -11445,11 +11445,11 @@ static int intel_crtc_page_flip(struct drm_crtc *crtc,
 
 	i915_gem_track_fb(intel_fb_obj(work->old_fb), obj,
 			  to_intel_plane(primary)->frontbuffer_bit);
+	mutex_unlock(&dev->struct_mutex);
 
 	intel_fbc_disable(dev);
 	intel_frontbuffer_flip_prepare(dev,
 				       to_intel_plane(primary)->frontbuffer_bit);
-	mutex_unlock(&dev->struct_mutex);
 
 	trace_i915_flip_request(intel_crtc->plane, obj);
 
-- 
2.1.4



More information about the Intel-gfx mailing list