[Intel-gfx] [PATCH 1/8] drm/i915: don't increment the FBC threshold at fbc_enable

[Chris Wilson]

On Tue, Jun 30, 2015 at 10:53:05AM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni <paulo.r.zanoni at intel.com>
> 
> We first set the threshold value when we're allocating the CFB, and
> then later at {ilk,gen7}_fbc_enable() we increment it in case we're
> using 16bpp. While that is correct, it is dangerous: if we rework the
> code a little bit in a way that allows us to call intel_fbc_enable()
> without necessarily calling i915_gem_stolen_setup_compression() first,
> we might end up incrementing threshold more than once. To prevent
> that, increment a temporary variable instead.
> 
> v2: Rebase.
> 
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni at intel.com>

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

You can move all the fbc out of i915_gem_stolen.c now that we have
intel_fbc.c. I don't even think we need to export a function to provide
drm_mm_insert_node(&dev_priv->mm.stolen), but we probably should for
ease of future maintenance.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre