[Intel-gfx] [PATCH 6/8] drm/i915: add struct_mutex WARNs to i915_gem_stolen.c

Chris Wilson chris at chris-wilson.co.uk
Tue Jun 30 14:00:49 PDT 2015


On Tue, Jun 30, 2015 at 01:30:27PM -0700, Jesse Barnes wrote:
> I think they serve as useful documentation at the very least, whether in
> lockdep form, WARN form, or BUG form.  It's not really something we can
> recover from either (maybe returning early before touching data?), so...

As a debug aide they are less useful than lockdep and no more useful
than lockdep for documentation purposes.

But it feels like more and more of the WARN_ONs are instead of error
handling. See the olr fiasco.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list