[Intel-gfx] [PATCH libdrm 00/12] Introduce drm_intel_device and use i915_pciid.h

[Ian Romanick]

Based on light reading, patches 1, 5, 6, 7, 8, 10, and 11 are

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

I sent a comment on patch 9.  I'll try to look at the others in the next
few days... assuming nobody beats me to it.

I'm also going to send some similar Mesa patches that I'll CC you on.

On 03/05/2015 08:20 AM, Damien Lespiau wrote:
> A couple of things I wanted to do for the longest time:
>   
>   - Have (intel's) libdrm use the kernel i915_pciids.h so we can just copy the
>     file when updating
>   - Start a new object, struct drm_intel_device where we could put common code
>     across several userspace projects. For instance it could be where we put
>     the "number of threads" logic we need to use in several 3d/gpgpu
>     states/instructions (that's a bit fiddly starting with CHV: we can't use
>     static tables anymore and need a runtime query to the kernel)
> 
> I tested it a bit so it can't be totally wrong:
> 
>   - I ran with this series on a couple of machines with no noticeable problem
>   - I check that the INTEL_DEVID_OVERRIDE env variable was still working (to
>     dump AUB files)
>   - make check, which exercises changes in the decoder path, still passes
>