[Intel-gfx] [PATCH] tests: Add test for pipe B and C interactions in IVB
Daniel Vetter
daniel at ffwll.ch
Tue Mar 10 12:05:08 PDT 2015
On Tue, Mar 10, 2015 at 02:35:56PM +0200, Ander Conselvan de Oliveira wrote:
> This actually only works if the machine is setup properly. It requires
> that:
>
> - the hardware to have at least two connected outpus;
> - the defatult mode on those outputs needs to be big enough;
> - the attached monitors need to support 10 bpc.
>
> This might generate spurius results if the connected output doesn't support
> 10bpc or a large enough mode.
>
> ---
> I used this to test the changes that affect pipe B and C interactions on
> IVB. I'm not really sure how to turn into a proper igt test though, because
> of the requirements on the outputs in use.
Sprinkle lots of igt_require(condition) over the testcase. In this case a
bit tricky since we'd need to look at the edid to check that there's a
10bpc screeen. Maybe use as an alternative plan just a higher resolution
and only check for the fdi per-lane dotclock limit? That should be more
reliable since for external outputs we start out with at least 8bpc
everywhere before deciding to dither down.
-Daniel
>
>
> ---
> tests/Makefile.sources | 1 +
> tests/kms_pipe_b_c_dpms.c | 173 ++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 174 insertions(+)
> create mode 100644 tests/kms_pipe_b_c_dpms.c
>
> diff --git a/tests/Makefile.sources b/tests/Makefile.sources
> index 9ab0ff4..9e43a64 100644
> --- a/tests/Makefile.sources
> +++ b/tests/Makefile.sources
> @@ -73,6 +73,7 @@ TESTS_progs_M = \
> kms_nuclear \
> kms_pipe_crc_basic \
> kms_plane \
> + kms_pipe_b_c_dpms \
> kms_psr_sink_crc \
> kms_render \
> kms_rotation_crc \
> diff --git a/tests/kms_pipe_b_c_dpms.c b/tests/kms_pipe_b_c_dpms.c
> new file mode 100644
> index 0000000..a5ed761
> --- /dev/null
> +++ b/tests/kms_pipe_b_c_dpms.c
> @@ -0,0 +1,173 @@
> +/*
> + * Copyright © 2015 Intel Corporation
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice (including the next
> + * paragraph) shall be included in all copies or substantial portions of the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> + * IN THE SOFTWARE.
> + *
> + * Authors:
> + * Ander Conselvan de Oliveira <ander.conselvan.de.oliveira at intel.com>
> + */
> +
> +#include "drmtest.h"
> +#include "igt_kms.h"
> +#include "intel_chipset.h"
> +
> +typedef struct {
> + int drm_fd;
> + igt_display_t display;
> +} data_t;
> +
> +static int
> +set_mode_on_pipe(data_t *data, enum pipe pipe, igt_output_t *output, int bpc)
> +{
> + igt_plane_t *primary;
> + drmModeModeInfo *mode;
> + struct igt_fb fb;
> + int fb_id;
> + uint32_t format;
> +
> + if (bpc == 8)
> + format = DRM_FORMAT_XRGB8888;
> + else if (bpc == 10)
> + format = DRM_FORMAT_XRGB2101010;
> + else
> + igt_fail(1);
> +
> + igt_output_set_pipe(output, pipe);
> +
> + /* FIXME: we need a big mode */
> + mode = igt_output_get_mode(output);
> + primary = igt_output_get_plane(output, 0);
> +
> + fb_id = igt_create_color_fb(data->drm_fd,
> + mode->hdisplay, mode->vdisplay,
> + format, I915_TILING_NONE,
> + 1.0, 1.0, 1.0, &fb);
> + igt_assert(fb_id >= 0);
> +
> + igt_plane_set_fb(primary, &fb);
> + return igt_display_try_commit2(&data->display, COMMIT_LEGACY);
> +}
> +
> +static int
> +set_big_mode_on_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
> +{
> + return set_mode_on_pipe(data, pipe, output, 10);
> +}
> +
> +static int
> +set_normal_mode_on_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
> +{
> + return set_mode_on_pipe(data, pipe, output, 8);
> +}
> +
> +static void
> +find_outputs(data_t *data, igt_output_t **output1, igt_output_t **output2)
> +{
> + int count = 0;
> + igt_output_t *output;
> +
> + *output1 = NULL;
> + *output2 = NULL;
> +
> + for_each_connected_output(&data->display, output) {
> + if (!(*output1))
> + *output1 = output;
> + else if (!(*output2))
> + *output2 = output;
> +
> + igt_output_set_pipe(output, PIPE_ANY);
> + count++;
> + }
> +
> + igt_skip_on_f(count < 2, "Not enough connected outputs\n");
> +}
> +
> +static void
> +test_dpms(data_t *data)
> +{
> + igt_output_t *output1, *output2;
> + int ret;
> +
> + find_outputs(data, &output1, &output2);
> +
> + igt_info("Pipe %s will use connector %s\n",
> + kmstest_pipe_name(PIPE_B), igt_output_name(output1));
> + igt_info("Pipe %s will use connector %s\n",
> + kmstest_pipe_name(PIPE_C), igt_output_name(output2));
> +
> + ret = set_big_mode_on_pipe(data, PIPE_B, output1);
> + igt_assert(ret == 0);
> +
> + kmstest_set_connector_dpms(data->drm_fd, output1->config.connector, DRM_MODE_DPMS_OFF);
> +
> + ret = set_big_mode_on_pipe(data, PIPE_C, output2);
> + igt_assert(ret != 0);
> +}
> +
> +static void
> +test_lane_reduction(data_t *data)
> +{
> + igt_output_t *output1, *output2;
> + int ret;
> +
> + find_outputs(data, &output1, &output2);
> +
> + igt_info("Pipe %s will use connector %s\n",
> + kmstest_pipe_name(PIPE_B), igt_output_name(output1));
> + igt_info("Pipe %s will use connector %s\n",
> + kmstest_pipe_name(PIPE_C), igt_output_name(output2));
> +
> + ret = set_big_mode_on_pipe(data, PIPE_B, output1);
> + igt_assert(ret == 0);
> +
> + ret = set_normal_mode_on_pipe(data, PIPE_B, output1);
> + igt_assert(ret == 0);
> +
> + ret = set_normal_mode_on_pipe(data, PIPE_C, output2);
> + igt_assert(ret == 0);
> +}
> +
> +static data_t data;
> +igt_main
> +{
> + int devid;
> +
> + igt_skip_on_simulation();
> +
> + igt_fixture {
> + data.drm_fd = drm_open_any_master();
> + devid = intel_get_drm_devid(data.drm_fd);
> +
> + kmstest_set_vt_graphics_mode();
> + igt_display_init(&data.display, data.drm_fd);
> + }
> +
> + igt_skip_on(!IS_IVYBRIDGE(devid));
> +
> + igt_subtest("pipe-B-dpms-off-modeset-pipe-C")
> + test_dpms(&data);
> +
> + igt_subtest("pipe-B-double-modeset-then-modeset-pipe-C")
> + test_lane_reduction(&data);
> +
> + igt_fixture {
> + igt_display_fini(&data.display);
> + }
> +}
> --
> 2.1.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
More information about the Intel-gfx
mailing list