[Intel-gfx] [PATCH 19/21] drm/i915: Enable skylake panel fitting using skylake shared scalers

[Daniel Vetter]

On Tue, Mar 17, 2015 at 08:43:02PM +0000, Konduru, Chandra wrote:
> 
> 
> > -----Original Message-----
> > From: Daniel Vetter [mailto:daniel.vetter at ffwll.ch] On Behalf Of Daniel Vetter
> > Sent: Tuesday, March 17, 2015 7:22 AM
> > To: Konduru, Chandra
> > Cc: intel-gfx at lists.freedesktop.org; Conselvan De Oliveira, Ander; Vetter, Daniel
> > Subject: Re: [Intel-gfx] [PATCH 19/21] drm/i915: Enable skylake panel fitting
> > using skylake shared scalers
> > 
> > On Sat, Mar 14, 2015 at 10:55:44PM -0700, Chandra Konduru wrote:
> > > Modify skylake panel fitting implementation to use shared scalers.
> > >
> > > Signed-off-by: Chandra Konduru <chandra.konduru at intel.com>
> > 
> > Ah here's the real pfit state, and the scaler state is just readout. Still we recover
> > this from the bios, I do think we need to make sure that at least the crtc scaler is
> > correctly assigned. Can't we recompute the scaler state after readout to make
> > sure it fits with pfit state here?
> > -Daniel
> 
> Crtc scaler can be computed from hw readout. As replied earlier, will be making 
> changes to update crtc scaler_id and appropriately set the scaler_users. 

When you add state readout suppoort for crtc scaler id, please also add
corresponding self-check code to intel_pipe_config_compare. That way we
can exercise all the fastboot code with normal igt testcases which
massively improves automated test coverage.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch