[Intel-gfx] [PATCH 2/2] drm/i915: kerneldoc for i915_gem_shrinker.c

[Chris Wilson]

On Wed, Mar 18, 2015 at 10:46:05AM +0100, Daniel Vetter wrote:
> +/**
> + * i915_gem_shrink - Shrink buffer object caches
> + * @dev_priv: i915 device
> + * @target: memory space to make available, in pages

Not memory space, too similar to VM address space.
@target: Amount of memory to make available, in pages

> + * @flags: control flags for selecting cache types
> + *
> + * This function is the main interface to the shrinker. It will try to release
> + * up to @target pages of memory backing storage from buffer objects.

Mention unpinned? Certainly we should try to explain part of the
interaction between pin_pages and pin here. (Though nowadays we have
clarified that slightly by pin explicitly doing a pin_pages.) We should
also mention that not everything we release here will generate freed
pages. (Hmm, though maybe we could change how we count to ensure target
free pages are generated? It still wouldn't help get_pages_gtt as there
is no guarantee that the pages we free will be given back to us...)
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre