[Intel-gfx] [PATCH] drm/i915: Keep ring->active_list and ring->requests_list consistent

Chris Wilson chris at chris-wilson.co.uk
Fri Mar 20 07:45:04 PDT 2015


On Fri, Mar 20, 2015 at 03:32:52PM +0100, Daniel Vetter wrote:
> But if we do that short-circuiting in ring_idle the all the requests
> _should_ be completed. Which meanse retire_request_ring should move all
> buffers to the inactive list, even when we do that before retiring
> requests.

We test for the requests to be retired after we test for the buffers to
be retired. It is very easy then for us to have active buffers as the
seqno advanced after the buffer retirement and before the requests. That
is (one of) the reasons why we previously sampled seqno only once when
retiring buffers + requests.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list