[Intel-gfx] [PATCH] drm/i915/skl: Fix up positive error code
Tvrtko Ursulin
tvrtko.ursulin at linux.intel.com
Tue Mar 24 07:11:55 PDT 2015
On 03/24/2015 01:16 PM, Jani Nikula wrote:
> On Tue, 24 Mar 2015, Tvrtko Ursulin <tvrtko.ursulin at linux.intel.com> wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>>
>> It should have been negative since it is returned with ERR_PTR().
>
> Please always reference the commit that introduced the issue.
Is there some more precisely defined criteria for "always"?
In this case this is at the moment dead code freshly merged to -nightly
only so ideally it would even be better to fix it up in the original
patch if possible?
Regards,
Tvrtko
More information about the Intel-gfx
mailing list