[Intel-gfx] [PATCH 7/7] drm/i915: Enable PSR by default.

[chris at chris-wilson.co.uk]

On Wed, Mar 25, 2015 at 07:27:35PM +0000, Vivi, Rodrigo wrote:
> On Tue, 2015-03-24 at 22:05 +0000, chris at chris-wilson.co.uk wrote:
> > On Tue, Mar 24, 2015 at 08:55:04PM +0000, Vivi, Rodrigo wrote:
> > > On Tue, 2015-03-24 at 10:08 +0000, Chris Wilson wrote:
> > > > On Tue, Mar 24, 2015 at 11:03:30AM +0100, Daniel Vetter wrote:
> > > > > On Mon, Mar 23, 2015 at 01:20:07PM -0700, Rodrigo Vivi wrote:
> > > > > > Hi Daniel,
> > > > > > 
> > > > > > Is something missing to enable it by default?
> > > > > 
> > > > > Patch 1 has a small comment from me and latest version of patch 2 lacks an
> > > > > r-b afaict. Hence why I didn't pull in the series yet. But it's also a
> > > > > longer discussion, so ca you please resend the entire series with r-b tags
> > > > > added to make sure I don't pick up the wrong versions?
> > > > 
> > > > Do I yet have a method to tell when PSR is active on an output?
> > > 
> > > Is that pre computed pipe_config->psr_enabled enough or you mean the
> > > immediate psr.active also exposed there on pipe_config?
> > 
> > I want a property exposed to userspace. Having a tristate that says
> > unsupported, disabled, active would be most useful.
> 
> I got your patch that added that and rebased on currently intel_psr.c
> changing transition and other small things and put here:
> 
> http://cgit.freedesktop.org/~vivijim/drm-intel/commit/?h=intel_psr&id=b99147c4849668a04e794003746fa22708406f56
> 
> But even with PSR transitioning well from idle to active, xrandr prop
> always shows me as idle:

You'll be falling foul of property caching. My immediate concern is
simply knowing when PSR is enabled on an output as a guide to knowing
when to avoid frontbuffer access. But IDLE/ACTIVE sound fun as well.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre